Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip injection of nvidia-persistenced socket by default #694

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Skip injection of nvidia-persistenced socket by default #694

merged 4 commits into from
Sep 18, 2024

Commits on Sep 18, 2024

  1. Skip injection of nvidia-persistenced socket by default 

    This changes skips the injection of the nvidia-persistenced socket by
default.

An include-persistenced-socket feature flag is added to allow the
injection of this socket to be explicitly requested.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
    @elezar
    elezar committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ba1ed32 View commit details
    Browse the repository at this point in the history

  2. Use include-persistenced-socket feature for CDI mode 

    This change ensures that the internal CDI representation includes
the persistenced socket if the include-persistenced-socket feature
flag is enabled.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
    @elezar
    elezar committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a4bfccc View commit details
    Browse the repository at this point in the history

  3. Allow inclusion of persistenced socket in CDI specification 

    This change adds an include-persistenced-socket flag to the
nvidia-ctk cdi generate command that ensures that a generated
specification includes the nvidia-persistenced socket if present on
the host.

Note that for mangement mode, these sockets are always included
if detected.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
    @elezar
    elezar committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    70da6cf View commit details
    Browse the repository at this point in the history

  4. Expose opt-in features in toolkit-container 

    This change enables opt-in (off-by-default) features to be opted into.
These features can be toggled by name by specifying the (repeated)
--opt-in-feature command line argument or as a comma-separated list
in the NVIDIA_CONTAINER_TOOLKIT_OPT_IN_FEATURES environment variable.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
    @elezar
    elezar committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9c2476c View commit details
    Browse the repository at this point in the history