Fix out of bound write handling for get_json_object_multiple_paths
#2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
ttnghia
changed the title
get_json_object_multiple_pathsget_json_object_multiple_paths
ttnghia
commented
Jul 31, 2024
Comment on lines
+1107
to
+1114
| for (std::size_t idx = 0; idx < oob_indices.size(); ++idx) { | ||
| auto const out_idx = oob_indices[idx]; | ||
| output[out_idx] = | ||
| cudf::make_strings_column(input.size(), | ||
| std::move(out_offsets_and_sizes[idx].first), | ||
| out_char_buffers[idx].release(), | ||
| out_null_masks_and_null_counts[idx].second, | ||
| std::move(out_null_masks_and_null_counts[idx].first)); |
There was a problem hiding this comment.
The indices out_idx and idx should be different. Previously they were the same. That is incorrect.
ttnghia
commented
Jul 31, 2024
| @@ -1112,7 +1093,7 @@ std::vector<std::unique_ptr<cudf::column>> get_json_object( | |||
| h_path_data, stream, rmm::mr::get_current_device_resource()); | |||
| thrust::uninitialized_fill( | |||
| rmm::exec_policy(stream), d_has_out_of_bound.begin(), d_has_out_of_bound.end(), 0); | |||
| kernel.exec(*d_input_ptr, d_path_data, stream); | |||
| kernel_launcher::exec(*d_input_ptr, d_path_data, stream); | |||
There was a problem hiding this comment.
When launching the kernel a second time, the number of paths is different from that number in launching the first time. Thus, the kernel launch parameters are different.
revans2
approved these changes
Aug 1, 2024
|
I ran through all of the JSON tests and redid the performance testing I did before. Everything passed as expected, because this is just here for a very odd corner case that is not going to ever be needed in practice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the code path for handling out-of-bound write when there are more than one JSON paths in
get_json_object_multiple_paths. Currently there are two issues with it:A unit test is also added to check for this particular code path.