Skip to content

Commit

Permalink
Temporarily allow 3.3.1 for 3.3.0 shims. (#5693) (#5700)
Browse files Browse the repository at this point in the history
Temporarily allow 3.3.1 while 3.3.0 release candidates are being produced

Signed-off-by: Firestarman <firestarmanllc@gmail.com>

Co-authored-by: Liangcai Li <firestarmanllc@gmail.com>
  • Loading branch information
tgravescs and firestarman authored May 31, 2022
1 parent 719fdb8 commit 15fad2a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@
<spark321cdh.version>3.2.1.3.2.7171000.0-3</spark321cdh.version>
<spark321db.version>3.2.1-databricks</spark321db.version>
<spark322.version>3.2.2-SNAPSHOT</spark322.version>
<spark330.version>3.3.0-SNAPSHOT</spark330.version>
<spark330.version>3.3.1-SNAPSHOT</spark330.version>
<spark340.version>3.4.0-SNAPSHOT</spark340.version>
<mockito.version>3.6.0</mockito.version>
<scala.plugin.version>4.3.0</scala.plugin.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ import com.nvidia.spark.rapids.SparkShimVersion

object SparkShimServiceProvider {
val VERSION = SparkShimVersion(3, 3, 0)
val VERSIONNAMES = Seq(s"$VERSION", s"$VERSION-SNAPSHOT")
// temporarily allow 3.3.1 while 3.3.0 release candidates are being produced
private val VERSION331 = SparkShimVersion(3, 3, 1)
val VERSIONNAMES = Seq(VERSION, VERSION331).flatMap(v => Seq(s"$v", s"$v-SNAPSHOT"))
}

class SparkShimServiceProvider extends com.nvidia.spark.rapids.SparkShimServiceProvider {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ import org.apache.spark.sql.types.{DayTimeIntervalType, YearMonthIntervalType}

class Spark330ShimsSuite extends FunSuite {
test("spark shims version") {
assert(SparkShimImpl.getSparkShimVersion === SparkShimVersion(3, 3, 0))
// temporarily allow 3.3.1 while 3.3.0 release candidates are being produced
assert(SparkShimImpl.getSparkShimVersion === SparkShimVersion(3, 3, 0) ||
SparkShimImpl.getSparkShimVersion === SparkShimVersion(3, 3, 1))
}

test("shuffle manager class") {
Expand Down

0 comments on commit 15fad2a

Please sign in to comment.