-
Notifications
You must be signed in to change notification settings - Fork 232
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
qualification tool: add filtering by app start time (#2940)
* Add logic to filter by time period Signed-off-by: Thomas Graves <tgraves@apache.org> * change name of param * fix matching default for days
- Loading branch information
Showing
5 changed files
with
241 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
146 changes: 146 additions & 0 deletions
146
tools/src/test/scala/com/nvidia/spark/rapids/tool/qualification/AppFilterSuite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| /* | ||
| * Copyright (c) 2021, NVIDIA CORPORATION. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.nvidia.spark.rapids.tool.qualification | ||
|
|
||
| import java.nio.charset.StandardCharsets | ||
| import java.nio.file.{Files, Paths} | ||
| import java.util.Calendar | ||
|
|
||
| import org.scalatest.FunSuite | ||
|
|
||
| import org.apache.spark.sql.TrampolineUtil | ||
| import org.apache.spark.sql.rapids.tool.AppFilterImpl | ||
|
|
||
| class AppFilterSuite extends FunSuite { | ||
|
|
||
| test("illegal args") { | ||
| assertThrows[IllegalArgumentException](AppFilterImpl.parseAppTimePeriod("0")) | ||
| assertThrows[IllegalArgumentException](AppFilterImpl.parseAppTimePeriod("1hd")) | ||
| assertThrows[IllegalArgumentException](AppFilterImpl.parseAppTimePeriod("1yr")) | ||
| assertThrows[IllegalArgumentException](AppFilterImpl.parseAppTimePeriod("-1d")) | ||
| assertThrows[IllegalArgumentException](AppFilterImpl.parseAppTimePeriod("0m")) | ||
| } | ||
|
|
||
| test("time period minute parsing") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.MINUTE, -6) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "10min") | ||
| } | ||
|
|
||
| test("time period hour parsing") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.HOUR, -10) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "14h") | ||
| } | ||
|
|
||
| test("time period day parsing") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.DATE, -40) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "41d") | ||
| } | ||
|
|
||
| test("time period day parsing default") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.DATE, -5) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "6") | ||
| } | ||
|
|
||
| test("time period week parsing") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.WEEK_OF_YEAR, -2) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "3w") | ||
| } | ||
|
|
||
| test("time period month parsing") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.MONTH, -8) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "10m") | ||
| } | ||
|
|
||
| test("time period minute parsing fail") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.MINUTE, -16) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "10min", failFilter=true) | ||
| } | ||
|
|
||
| test("time period hour parsing fail") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.HOUR, -10) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "8h", failFilter=true) | ||
| } | ||
|
|
||
| test("time period day parsing fail") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.DATE, -40) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "38d", failFilter=true) | ||
| } | ||
|
|
||
| test("time period week parsing fail") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.WEEK_OF_YEAR, -2) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "1w", failFilter=true) | ||
| } | ||
|
|
||
| test("time period month parsing fail") { | ||
| val c = Calendar.getInstance | ||
| c.add(Calendar.MONTH, -8) | ||
| val newTimeStamp = c.getTimeInMillis | ||
| testTimePeriod(newTimeStamp, "7m", failFilter=true) | ||
| } | ||
|
|
||
| private def testTimePeriod(eventLogTime: Long, startTimePeriod: String, | ||
| failFilter: Boolean = false): Unit = { | ||
| TrampolineUtil.withTempDir { outpath => | ||
| TrampolineUtil.withTempDir { tmpEventLogDir => | ||
|
|
||
| val elogFile = Paths.get(tmpEventLogDir.getAbsolutePath, "testTimeEventLog") | ||
|
|
||
| // scalastyle:off line.size.limit | ||
| val supText = | ||
| s"""{"Event":"SparkListenerLogStart","Spark Version":"3.1.1"} | ||
| |{"Event":"SparkListenerApplicationStart","App Name":"Spark shell","App ID":"local-1626104300434","Timestamp":${eventLogTime},"User":"user1"}""".stripMargin | ||
| // scalastyle:on line.size.limit | ||
| Files.write(elogFile, supText.getBytes(StandardCharsets.UTF_8)) | ||
|
|
||
| val allArgs = Array( | ||
| "--output-directory", | ||
| outpath.getAbsolutePath(), | ||
| "--start-app-time", | ||
| startTimePeriod | ||
| ) | ||
| val appArgs = new QualificationArgs(allArgs ++ Array(elogFile.toString())) | ||
| val (exit, appSum) = QualificationMain.mainInternal(appArgs) | ||
| assert(exit == 0) | ||
| if (failFilter) { | ||
| assert(appSum.size == 0) | ||
| } else { | ||
| assert(appSum.size == 1) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |