fix resource leak in to_json (#9879)

Signed-off-by: Andy Grove <andygrove@nvidia.com>
NVIDIA · Nov 29, 2023 · 31aee63 · 31aee63
1 parent 7efcb81
commit 31aee63
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala
@@ -1124,13 +1124,15 @@ object GpuCast {
           }
           if (options.ignoreNullFieldsInStructs) {
             // write the value
-            val attrValue = castToString(cv, inputSchema(fieldIndex).dataType, options)
-            if (needsQuoting) {
-              attrColumns += quote.incRefCount()
-              attrColumns += escapeJsonString(attrValue)
-              attrColumns += quote.incRefCount()
-            } else {
-              attrColumns += attrValue
+            withResource(castToString(cv, inputSchema(fieldIndex).dataType, options)) {
+                attrValue =>
+              if (needsQuoting) {
+                attrColumns += quote.incRefCount()
+                attrColumns += escapeJsonString(attrValue)
+                attrColumns += quote.incRefCount()
+              } else {
+                attrColumns += attrValue.incRefCount()
+              }
             }
             // now concatenate
             val jsonAttr = withResource(Scalar.fromString("")) { emptyString =>