Skip to content

Commit

Permalink
enable approx percentile tests (#4400)
Browse files Browse the repository at this point in the history
Signed-off-by: Andy Grove <andygrove@nvidia.com>
  • Loading branch information
andygrove authored Jan 10, 2022
1 parent 8773141 commit 3a0df72
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions integration_tests/src/main/python/hash_aggregate_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1327,7 +1327,6 @@ def test_hash_groupby_approx_percentile_byte_scalar(aqe_enabled):
('v', ByteGen())], length=100),
0.5, conf)

@pytest.mark.skip(reason="https://github.com/NVIDIA/spark-rapids/issues/4060")
@pytest.mark.parametrize('aqe_enabled', ['false', 'true'], ids=idfn)
def test_hash_groupby_approx_percentile_long_repeated_keys(aqe_enabled):
conf = copy_and_update(_approx_percentile_conf, {'spark.sql.adaptive.enabled': aqe_enabled})
Expand All @@ -1336,7 +1335,6 @@ def test_hash_groupby_approx_percentile_long_repeated_keys(aqe_enabled):
('v', LongRangeGen())], length=100),
[0.05, 0.25, 0.5, 0.75, 0.95], conf)

@pytest.mark.skip(reason="https://github.com/NVIDIA/spark-rapids/issues/4060")
@pytest.mark.parametrize('aqe_enabled', ['false', 'true'], ids=idfn)
def test_hash_groupby_approx_percentile_long(aqe_enabled):
conf = copy_and_update(_approx_percentile_conf, {'spark.sql.adaptive.enabled': aqe_enabled})
Expand All @@ -1345,7 +1343,6 @@ def test_hash_groupby_approx_percentile_long(aqe_enabled):
('v', LongRangeGen())], length=100),
[0.05, 0.25, 0.5, 0.75, 0.95], conf)

@pytest.mark.skip(reason="https://github.com/NVIDIA/spark-rapids/issues/4060")
@pytest.mark.parametrize('aqe_enabled', ['false', 'true'], ids=idfn)
def test_hash_groupby_approx_percentile_long_single(aqe_enabled):
conf = copy_and_update(_approx_percentile_conf, {'spark.sql.adaptive.enabled': aqe_enabled})
Expand Down Expand Up @@ -1388,15 +1385,13 @@ def approx_percentile_query(spark):

assert_gpu_fallback_collect(lambda spark: approx_percentile_query(spark), 'ApproximatePercentile', conf)

@pytest.mark.skip(reason="https://github.com/NVIDIA/spark-rapids/issues/4060")
@ignore_order(local=True)
def test_hash_groupby_approx_percentile_decimal32():
compare_percentile_approx(
lambda spark: gen_df(spark, [('k', RepeatSeqGen(ByteGen(nullable=False), length=2)),
('v', DecimalGen(6, 2))]),
[0.05, 0.25, 0.5, 0.75, 0.95], conf = _approx_percentile_conf)

@pytest.mark.skip(reason="https://github.com/NVIDIA/spark-rapids/issues/4060")
@ignore_order(local=True)
def test_hash_groupby_approx_percentile_decimal32_single():
compare_percentile_approx(
Expand Down

0 comments on commit 3a0df72

Please sign in to comment.