Skip to content

Commit

Permalink
Fix missing dataSize metric when using RAPIDS shuffle (#986)
Browse files Browse the repository at this point in the history
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
  • Loading branch information
jlowe authored Oct 21, 2020
1 parent 8fe81e7 commit 3a96362
Showing 1 changed file with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,15 @@ abstract class GpuShuffleExchangeExecBase(
SQLShuffleWriteMetricsReporter.createShuffleWriteMetrics(sparkContext)
lazy val readMetrics =
SQLShuffleReadMetricsReporter.createShuffleReadMetrics(sparkContext)
override lazy val additionalMetrics : Map[String, SQLMetric] = Map(
"dataSize" -> SQLMetrics.createSizeMetric(sparkContext, "data size")
) ++ readMetrics ++ writeMetrics

// Spark doesn't report totalTime for this operator so we override metrics directly rather
// than use additionalMetrics
// Spark doesn't report totalTime for this operator so we override metrics
override lazy val metrics: Map[String, SQLMetric] = Map(
NUM_OUTPUT_ROWS -> SQLMetrics.createMetric(sparkContext, DESCRIPTION_NUM_OUTPUT_ROWS),
NUM_OUTPUT_BATCHES -> SQLMetrics.createMetric(sparkContext, DESCRIPTION_NUM_OUTPUT_BATCHES),
"dataSize" -> SQLMetrics.createSizeMetric(sparkContext, "data size")) ++
readMetrics ++ writeMetrics
NUM_OUTPUT_BATCHES -> SQLMetrics.createMetric(sparkContext, DESCRIPTION_NUM_OUTPUT_BATCHES)
) ++ additionalMetrics

override def nodeName: String = "GpuColumnarExchange"

Expand Down

0 comments on commit 3a96362

Please sign in to comment.