Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] injecting split and retry via injectRetryOOM triggers for withRetry that can't handle it #10184

Open
abellina opened this issue Jan 11, 2024 · 0 comments
Labels
bug Something isn't working reliability Features to improve reliability or bugs that severly impact the reliability of the plugin test Only impacts tests

Comments

@abellina
Copy link
Collaborator

The reason OOM injection works with CI is that we inject OOM in those places that can handle it (they have a withRetry). Recently, we added the ability to inject a "split and retry", however, we are not triggering these exceptions when inside of a withRetry that has a split function defined, instead we inject these for all withRetry flavors, which I don't think is what we want.

I would like to change the injection mechanism for split and retry so we make sure we don't inject if our scope isn't ready for it.

@abellina abellina added bug Something isn't working ? - Needs Triage Need team to review and classify test Only impacts tests labels Jan 11, 2024
@mattahrens mattahrens added reliability Features to improve reliability or bugs that severly impact the reliability of the plugin and removed ? - Needs Triage Need team to review and classify labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reliability Features to improve reliability or bugs that severly impact the reliability of the plugin test Only impacts tests
Projects
None yet
Development

No branches or pull requests

2 participants