Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] add split and retry integration tests for GpuGenerate #10185

Open
abellina opened this issue Jan 11, 2024 · 0 comments
Open

[FEA] add split and retry integration tests for GpuGenerate #10185

abellina opened this issue Jan 11, 2024 · 0 comments
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin test Only impacts tests

Comments

@abellina
Copy link
Collaborator

We currently don't test with split and retry in our python integration tests. This issue would be the first time we do this, specifically for GpuGenerateExec, as that where I noticed it last.

Currently our CI cycles between injecting or not injecting retry randomly. I think we should consider injecting split and retry, if and only if the scope is equipped to support it.

This issue is blocked on: #10184. Both could be solved in the same (this) ticket.
@abellina abellina added feature request New feature or request ? - Needs Triage Need team to review and classify test Only impacts tests labels Jan 11, 2024
@abellina abellina mentioned this issue Jan 11, 2024
Merged
@mattahrens mattahrens added reliability Features to improve reliability or bugs that severly impact the reliability of the plugin and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abellina @mattahrens