Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add pytests for partial and final mode on the GPU for hash aggregate tests #110

Closed
kuhushukla opened this issue Jun 4, 2020 · 0 comments · Fixed by #157
Closed

[FEA] Add pytests for partial and final mode on the GPU for hash aggregate tests #110

kuhushukla opened this issue Jun 4, 2020 · 0 comments · Fixed by #157
Assignees
@kuhushukla
Labels
feature request New feature or request SQL part of the SQL/Dataframe plugin test Only impacts tests
Milestone
Jun 8 - Jun 19

Comments

@kuhushukla
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Add tests that use partial only and final only conf modes for hash aggregate.
Currently conf is initialized as a global val and passed into all the relevant hash aggregate tests that need it. If one would want to test the same test query with a different conf, they would have to duplicate the test.

Describe the solution you'd like
It would be nice to reuse test code and allow config to be passed in as a param, so that we can test cases where the hash aggregate is on the GPU in partial and/or final mode.
Relates as a follow on to #107
@kuhushukla kuhushukla added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jun 4, 2020
@kuhushukla kuhushukla self-assigned this Jun 4, 2020
@kuhushukla kuhushukla added SQL part of the SQL/Dataframe plugin test Only impacts tests and removed ? - Needs Triage Need team to review and classify SQL part of the SQL/Dataframe plugin labels Jun 4, 2020
@kuhushukla kuhushukla mentioned this issue Jun 11, 2020
Merged
@sameerz sameerz added this to the Jun 8 - Jun 19 milestone Jun 15, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 4596244 (NVIDIA#110)
7c3b954 
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuhushukla kuhushukla

Labels
feature request New feature or request SQL part of the SQL/Dataframe plugin test Only impacts tests
Projects
None yet
Milestone
Jun 8 - Jun 19
2 participants
@sameerz @kuhushukla