Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] LIKE does not work if null chars are in the string #119

Closed
revans2 opened this issue Jun 5, 2020 · 2 comments · Fixed by #4682
Closed

[BUG] LIKE does not work if null chars are in the string #119

revans2 opened this issue Jun 5, 2020 · 2 comments · Fixed by #4682
Labels
bug Something isn't working P1 Nice to have for release SQL part of the SQL/Dataframe plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented Jun 5, 2020

Describe the bug
This is a very odd corner case, but if a null char '\0' is in the string like sees it as the end of the string. So 'A\0FOO BAR' will match '_'. This is a very odd and rare corner case so we probably can ignore it for now, but we need to have it documented. I think this impacts all cudf regular expressions and we need to probably file a follow on issue with them to look into it.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify SQL part of the SQL/Dataframe plugin labels Jun 5, 2020
@sameerz sameerz added P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Aug 18, 2020
@sameerz
Copy link
Collaborator

sameerz commented Aug 18, 2020

Need to document this behavior for the 0.2 release. The fix / change can be in a subsequent release.

@sameerz sameerz self-assigned this Aug 19, 2020
sameerz added a commit to sameerz/spark-rapids that referenced this issue Aug 27, 2020
@sameerz
Added .md extension, added documentation for issue NVIDIA#119.
baafdae 
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@sameerz sameerz mentioned this issue Aug 27, 2020
Merged
sameerz added a commit that referenced this issue Aug 28, 2020
@sameerz
Documentation updates for branch 0.2 (#617)
d758cb4 
* Documentation updates for branch 0.2

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Added .md extension, added documentation for issue #119.

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Add back .md extensions on links

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Update get-started/getting-started.md link in index.md

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Fix getting started link in testing.md

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@revans2
Copy link
Collaborator Author

revans2 commented Sep 10, 2020

I filed rapidsai/cudf#6196 for this.

@sameerz sameerz removed their assignment Feb 4, 2021
@GaryShen2008 GaryShen2008 mentioned this issue Apr 7, 2021
Closed
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@sameerz
Documentation updates for branch 0.2 (NVIDIA#617)
c296db6 
* Documentation updates for branch 0.2

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Added .md extension, added documentation for issue NVIDIA#119.

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Add back .md extensions on links

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Update get-started/getting-started.md link in index.md

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Fix getting started link in testing.md

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@sameerz
Documentation updates for branch 0.2 (NVIDIA#617)
c593166 
* Documentation updates for branch 0.2

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Added .md extension, added documentation for issue NVIDIA#119.

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Add back .md extensions on links

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Update get-started/getting-started.md link in index.md

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Fix getting started link in testing.md

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@andygrove andygrove mentioned this issue Feb 2, 2022
Merged
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 21ed251 (NVIDIA#119)
a236569 
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P1 Nice to have for release SQL part of the SQL/Dataframe plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable test for LIKE with embedded null character andygrove/spark-rapids
2 participants
@revans2 @sameerz