Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Host columnar decimal conversions are failing #1348

Closed
jlowe opened this issue Dec 9, 2020 · 1 comment
Closed

[BUG] Host columnar decimal conversions are failing #1348

jlowe opened this issue Dec 9, 2020 · 1 comment
Assignees
@revans2
Labels
bug Something isn't working P0 Must have for release SQL part of the SQL/Dataframe plugin

Comments

@jlowe
Copy link
Member

jlowe commented Dec 9, 2020

As reported in #1279 and #1280 there are issues converting columnar host decimals to GPU decimals. Those issues were "fixed" by disabling the decimal type by default, but the root cause needs to be investigated and fixed.
@jlowe jlowe added bug Something isn't working SQL part of the SQL/Dataframe plugin P0 Must have for release labels Dec 9, 2020
@revans2 revans2 self-assigned this Dec 9, 2020
@revans2
Copy link
Collaborator

revans2 commented Dec 9, 2020

Found the bug. In our conversion code we passed in the full 64 bit precision, but that the onheap column vector could store the data as a 32 bit value, which is why we got the errors.

I'll put up a fix tomorrow.

@revans2 revans2 mentioned this issue Dec 10, 2020
Merged
@revans2 revans2 closed this as completed Dec 11, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 20c3aaba97d69bccd0e0bac90d57ec722437bd9b (NV…
82c5b4c 
…IDIA#1348)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
bug Something isn't working P0 Must have for release SQL part of the SQL/Dataframe plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlowe @revans2