Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-merge should handle specific non-mergeable failures #1363

Closed
pxLi opened this issue Dec 10, 2020 · 1 comment
Closed

auto-merge should handle specific non-mergeable failures #1363

pxLi opened this issue Dec 10, 2020 · 1 comment
Assignees
@pxLi
Labels
build Related to CI / CD or cleanly building task Work required that improves the product but is not user facing

Comments

@pxLi
Copy link
Collaborator

pxLi commented Dec 10, 2020

For auto-merge, we should be able to handle all kinds of non-mergeable failures. Like,

  1. if it failed due to merge conflict, it should wait for manual fix like right now
  2. if it failed due to PR's sha update, auto-merge should refresh local sha and try merge again
  3. ....

Currently github API would only return us the 405 error code for non-mergeable cases, we will need to add some logic to identify specific reasons of non-mergeable failures and deal w/ it correctly
@pxLi pxLi added feature request New feature or request ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building labels Dec 10, 2020
@pxLi pxLi mentioned this issue Dec 10, 2020
Merged
@pxLi pxLi self-assigned this Dec 10, 2020
@sameerz sameerz changed the title [FEA] auto-merge should handle specific non-mergeable failures auto-merge should handle specific non-mergeable failures Dec 15, 2020
@sameerz sameerz added test Only impacts tests task Work required that improves the product but is not user facing and removed ? - Needs Triage Need team to review and classify feature request New feature or request test Only impacts tests labels Dec 15, 2020
@GaryShen2008 GaryShen2008 added the P1 Nice to have for release label Feb 21, 2021
@pxLi
Copy link
Collaborator Author

pxLi commented Apr 12, 2021

Going to close this one since #1358 already fixed the issue.
If we saw this again, I will spend some time to optimize the auto-merge script

@pxLi pxLi closed this as completed Apr 12, 2021
@pxLi pxLi removed the P1 Nice to have for release label Apr 12, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@gerashegalov
Avoid using invlalid null_mask for zero null_count (NVIDIA#1364)
853a79a 
Fixes NVIDIA#1363

- adds a unit test reproducing the issue
- adds a null_count check

Signed-off-by: Gera Shegalov <gera@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pxLi pxLi

Labels
build Related to CI / CD or cleanly building task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sameerz @pxLi @GaryShen2008