Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Audit: add unit tests for predicate push down #147

Closed
revans2 opened this issue Jun 10, 2020 · 1 comment
Closed

[FEA] Audit: add unit tests for predicate push down #147

revans2 opened this issue Jun 10, 2020 · 1 comment
Labels
feature request New feature or request P1 Nice to have for release SQL part of the SQL/Dataframe plugin test Only impacts tests

Comments

@revans2
Copy link
Collaborator

revans2 commented Jun 10, 2020

Is your feature request related to a problem? Please describe.
The current predicate push down tests verify that the output is correct, but do nothing to verify that we actually pushed down the predicates and read less data. This is probably best done in the form of a real unit test.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify SQL part of the SQL/Dataframe plugin test Only impacts tests labels Jun 10, 2020
@kuhushukla kuhushukla mentioned this issue Jul 1, 2020
Closed
@kuhushukla kuhushukla self-assigned this Jul 7, 2020
@kuhushukla kuhushukla added this to the Jul 6 - Jul 17 milestone Jul 7, 2020
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jul 7, 2020
@sameerz sameerz removed this from the Jul 6 - Jul 17 milestone Jul 22, 2020
@sameerz sameerz added the P1 Nice to have for release label Jul 22, 2020
@kuhushukla kuhushukla changed the title [FEA] add unit tests for predicate push down [FEA] Audit: add unit tests for predicate push down Aug 12, 2020
@sameerz sameerz added this to the Aug 17 - Aug 28 milestone Aug 14, 2020
@kuhushukla kuhushukla removed this from the Aug 31 - Sep 11 milestone Sep 9, 2020
@kuhushukla kuhushukla removed their assignment Jan 6, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 9a62a37 (NVIDIA#147)
59c2e04 
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
@jlowe
Copy link
Member

jlowe commented Jan 24, 2024

Fixed by #9128.

@jlowe jlowe closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request P1 Nice to have for release SQL part of the SQL/Dataframe plugin test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jlowe @revans2 @sameerz @kuhushukla