Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] BenchmarkRunner does not include query name in JSON summary filename when running multiple queries #1650

Closed
andygrove opened this issue Feb 2, 2021 · 0 comments · Fixed by #1663
Closed

[BUG] BenchmarkRunner does not include query name in JSON summary filename when running multiple queries #1650

andygrove opened this issue Feb 2, 2021 · 0 comments · Fixed by #1663
Assignees
@nartal1
Labels
benchmark Benchmarking, benchmarking tools bug Something isn't working
Milestone
Feb 1 - Feb 12

Comments

@andygrove
Copy link
Contributor

andygrove commented Feb 2, 2021 •
edited
Loading

Describe the bug
When running BenchmarkRunner with multiple queries, it is not possible to specify a summary-file-prefix that contains the individual query names, making it time-consuming to differentiate between the generated files.

It would be good to have the ability to provide a file prefix that includes a variable for the query name. For example: --summary-file-prefix my-${QUERY}-tests.
@andygrove andygrove added bug Something isn't working ? - Needs Triage Need team to review and classify benchmark Benchmarking, benchmarking tools labels Feb 2, 2021
@andygrove andygrove added this to the Feb 1 - Feb 12 milestone Feb 2, 2021
@andygrove andygrove self-assigned this Feb 2, 2021
@andygrove andygrove assigned nartal1 and unassigned andygrove Feb 2, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 2, 2021
@nartal1 nartal1 mentioned this issue Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nartal1 nartal1

Labels
benchmark Benchmarking, benchmarking tools bug Something isn't working
Projects
None yet
Milestone
Feb 1 - Feb 12
Development

Successfully merging a pull request may close this issue.

BenchmarkRunner - Include query name in JSON summary filename nartal1/spark-rapids
3 participants
@andygrove @sameerz @nartal1