Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BenchmarkRunner - Include query name in JSON summary filename #1663

Merged
merged 4 commits into from
Feb 3, 2021

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Feb 3, 2021

This fixes #1650.
Signed-off-by: Niranjan Artal nartal@nvidia.com

Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@nartal1 nartal1 added the bug Something isn't working label Feb 3, 2021
@nartal1 nartal1 added this to the Feb 1 - Feb 12 milestone Feb 3, 2021
@nartal1 nartal1 self-assigned this Feb 3, 2021
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Copy link
Contributor

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and LGTM

@andygrove
Copy link
Contributor

build

@nartal1 nartal1 merged commit 8c6947a into NVIDIA:branch-0.4 Feb 3, 2021
nartal1 added a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
nartal1 added a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] BenchmarkRunner does not include query name in JSON summary filename when running multiple queries
2 participants