Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Audit ProjectExec #231

Closed
kuhushukla opened this issue Jun 19, 2020 · 1 comment
Closed

[FEA] Audit ProjectExec #231

kuhushukla opened this issue Jun 19, 2020 · 1 comment
Assignees
Labels
feature request New feature or request

Comments

@kuhushukla
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

  • Ensure Spark and Rapids plugin version of the exec match functionality.

  • Verify Config specific to the operator match.

  • Verify API is consistent and fully translated.

  • Port relevant tests.

@kuhushukla kuhushukla added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jun 19, 2020
@kuhushukla kuhushukla self-assigned this Jun 19, 2020
@kuhushukla kuhushukla added this to the Jun 22 - Jul 2 milestone Jun 19, 2020
@kuhushukla kuhushukla removed the ? - Needs Triage Need team to review and classify label Jul 1, 2020
@kuhushukla
Copy link
Collaborator Author

kuhushukla commented Jul 1, 2020

  • Ensure Spark and Rapids plugin version of the exec match functionality.
    They do, minor nit is we can have projectList be a seq(NamedExpression) instead of just seq(Expression) but that is minor and mostly for api one to one matching. Keeping this issue open to fix that. (EDIT: closing as this is benign)

  • Verify Config specific to the operator match.
    It does.

  • Verify API is consistent and fully translated.
    It is. There are some expression evaluation optimizations which we handle very differently so it should stay as is.

  • Port relevant tests.
    Project exec is a simple exec that is used in many places and looking at the tests it is mostly for plan verification which I think is a benign change to our unit tests that seems unnecessary.

tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant