Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] widen the rendered Jekyll pages #340

Closed
abellina opened this issue Jul 9, 2020 · 1 comment · Fixed by #624
Closed

[FEA] widen the rendered Jekyll pages #340

abellina opened this issue Jul 9, 2020 · 1 comment · Fixed by #624
Assignees
Labels
documentation Improvements or additions to documentation feature request New feature or request P1 Nice to have for release

Comments

@abellina
Copy link
Collaborator

abellina commented Jul 9, 2020

The current configs.html (from configs.md) has scrollers to deal with the wide Expressions table. I think we can probably make the site centered-left, and make the right pane fluid so it fills the rest of the page. Note that we are adding a column to this table, so it'll just get wider.

https://nvidia.github.io/spark-rapids/docs/configs.html

@abellina abellina added documentation Improvements or additions to documentation feature request New feature or request ? - Needs Triage Need team to review and classify labels Jul 9, 2020
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jul 11, 2020
@sameerz sameerz self-assigned this Jul 11, 2020
@sameerz sameerz added the P1 Nice to have for release label Jul 22, 2020
@sameerz
Copy link
Collaborator

sameerz commented Aug 28, 2020

I did some research on the sidebar width. It is possible to reduce the sidebar. It is difficult to reduce the sidebar to make the last column in the Supported GPU Operators and Fine Tuning section completely visible.

The following settings in the _sass/color_schemes/emerald.scss theme file (which only exists in the gh-pages branch) get us close:

$content-width: 1000px;
$nav-width: 264px;

Here is a brief explanation of what these do:

For screen widths minimum 66.5rem, the .side-bar width is the (width of the parent element minus the $nav-width + $content-width ) / 2 plus the $nav-width
To reduce the sidebar increase the $content-width variable, which is defined as 800px by default
See also https://github.com/pmarsceill/just-the-docs/blob/master/_sass/layout.scss for the definition of .side-bar and the custom.scss file for default variable values
The generated value in just-the-docs-default.css will be:
@media (min-width: 66.5rem) { .side-bar { width: calc((100% - 1264px) / 2 + 264px); min-width: 264px; } }

Below are screenshots comparing the before and after width in jekyll on a 1280x800 display. An alternative to address the problem with the Expressions table is to put the notes, which are very long but infrequent, as footnotes to the table.

Screen Shot 2020-08-27 at 11 19 44 PM

Screen Shot 2020-08-27 at 11 20 44 PM

@sameerz sameerz linked a pull request Aug 28, 2020 that will close this issue
@sameerz sameerz closed this as completed Aug 28, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request New feature or request P1 Nice to have for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants