New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] dup GpuHashJoin.diff case-folding issue #4593

Closed

pxLi opened this issue Jan 21, 2022 · 0 comments · Fixed by #4594

Labels

bug

Collaborator

pxLi commented Jan 21, 2022 •

edited

Loading

Describe the bug
#4529
#4585
introduced
GpuhashJoin.diff and GpuHashJoin.diff
case-folding issue for different OSs

which confused local checkout on mac

--- a/scripts/spark2diffs/GpuHashJoin.diff
+++ b/scripts/spark2diffs/GpuHashJoin.diff
@@ -6,9 +6,13 @@
 < object GpuHashJoin {
 ---
 > object GpuHashJoin extends Arm {
-101a102
+72c72
+<       meta: RapidsMeta[_, _],
+---
+>       meta: RapidsMeta[_, _, _],
+99a100
 >
-122c123
+120c121
 < }
 ---
 >

The text was updated successfully, but these errors were encountered:

pxLi added bug ? - Needs Triage labels

pxLi mentioned this issue

Resolve case-folding issue [skip ci] #4594

Merged

pxLi removed the ? - Needs Triage label

pxLi closed this as completed in #4594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment