Spark2 module upmerge, deploy script, and updates for Jenkins #4585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
revans2
as code owners
|
build |
jlowe
reviewed
Jan 20, 2022
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
|
build |
jlowe
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upmerge spark2 module to latest, pulls changes from:
0d236d8
Update the deploy script to deploy the new spark2 jar. Unfortunately I haven't tested them because the test deploy build is failing for something different, working with @NvTimLiu
Added some docs to the script for developers to give them an idea on how to deal with it.
Update the diff script to error out properly only when actual diff in diff files.
Changed the aggregate diff to not use git so we could more easily run from jenkins build.
fixes #4360