Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] GpuStringSplit: Add support for limit = 0 and limit =1 #4720

Closed
andygrove opened this issue Feb 8, 2022 · 0 comments · Fixed by #5932
Closed

[FEA] GpuStringSplit: Add support for limit = 0 and limit =1 #4720

andygrove opened this issue Feb 8, 2022 · 0 comments · Fixed by #5932
Assignees
@anthony-chang
Labels
feature request New feature or request

Comments

@andygrove
Copy link
Contributor

andygrove commented Feb 8, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
PR #4714 adds support for GpuStringSplit with regular expressions but does not support limit of 0 or 1.

Describe the solution you'd like
I would like support for limit of 0 or 1 and the following tests in string_tests.py should be updated:

  • test_split_zero_limit_fallback
  • test_split_one_limit_fallback
  • test_split_re_zero_limit_fallback
  • test_split_re_one_limit_fallback

Describe alternatives you've considered
None

Additional context
None
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 8, 2022
This was referenced Feb 8, 2022
Open
Merged
@andygrove andygrove changed the title [FEA] GpuStringSplit: Add support for limit = 0 and limit =1 when used with regular expressions [FEA] GpuStringSplit: Add support for limit = 0 and limit =1 Feb 8, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 8, 2022
@anthony-chang anthony-chang self-assigned this Jun 23, 2022
@anthony-chang anthony-chang mentioned this issue Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthony-chang anthony-chang

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add string split support for limit = 0 and limit =1 anthony-chang/spark-rapids
3 participants
@andygrove @sameerz @anthony-chang