Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string split support for limit = 0 and limit =1 #5932

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Add string split support for limit = 0 and limit =1 #5932

merged 2 commits into from
Jul 6, 2022

Conversation

anthony-chang
Copy link
Contributor

Closes #4720

This PR adds support for GpuStringSplit with a limit of 0 or 1.

  • For a limit of 0 it splits as many times as possible, so it is equivalent to a split with any negative limit.
  • For a limit of 1, it doesn't perform any splits so we just return a list containing only the original string.

@anthony-chang anthony-chang self-assigned this Jun 29, 2022
@anthony-chang
Copy link
Contributor Author

build

@jlowe jlowe added this to the Jun 20 - Jul 8 milestone Jun 29, 2022
@sameerz sameerz added the feature request New feature or request label Jul 1, 2022
@anthony-chang anthony-chang merged commit adf2f95 into NVIDIA:branch-22.08 Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@NVnavkumar NVnavkumar Awaiting requested review from NVnavkumar

Assignees

@anthony-chang anthony-chang

Labels
feature request New feature or request
Projects
None yet
Milestone
Jun 20 - Jul 8
Development

Successfully merging this pull request may close these issues.

[FEA] GpuStringSplit: Add support for limit = 0 and limit =1
3 participants
@anthony-chang @jlowe @sameerz