Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] validate values for critical build properties #4852

Closed
gerashegalov opened this issue Feb 23, 2022 · 1 comment
Closed

[FEA] validate values for critical build properties #4852

gerashegalov opened this issue Feb 23, 2022 · 1 comment
Labels
build Related to CI / CD or cleanly building

Comments

@gerashegalov
Copy link
Collaborator

gerashegalov commented Feb 23, 2022

Is your feature request related to a problem? Please describe.
As a new developer I would like the build to fail if invalid values are specified.

Describe the solution you'd like
Use maven enforcer plugin to validate subtle properties https://maven.apache.org/enforcer/enforcer-rules/requireProperty.html

Describe alternatives you've considered

  1. Only use static profiles for building without allowing customization via -D
  2. deprecate direct maven usage and settle to a script like buildall and restrict and validate params there.

Additional context
a user experienced a subtle validation issue

[ERROR] /rapids-plugin/dist/maven-antrun/build-parallel-worlds.xml:133: exec check-shims-revisions.sh failed, exit code is 1, error msg is Check Failed: git revisions between shims are not equal
[ERROR] Please check the revisions of each shim to see which one is inconsistent. Note, if building with Databricks those jars are built separately.

which was too far away from the root cause that ended up being an invalid value for the buildver property

@gerashegalov gerashegalov added feature request New feature or request ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building labels Feb 23, 2022
@sameerz sameerz removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Mar 1, 2022
@gerashegalov
Copy link
Collaborator Author

We already have enforcer as part of our build and it validates Maven, and Java versions e.g. #9615 .

Misspelled buildver is no longer possible because of the spark-rapids-private dependency would fail the build on the incorrect spark.version.classifer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

No branches or pull requests

2 participants