Bloop updates - require JDK11 in buildall + docs, build bloop for all targets. #9615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… targets. Signed-off-by: Phil Dakin <phil.dakin.1@gmail.com>
PhilDakin
force-pushed
the
pdakin.20231030.bloop_fixes
branch
from
2aa6b4f
to
682930a
Compare
sameerz
added
bug
gerashegalov
reviewed
Nov 2, 2023
Signed-off-by: Phil Dakin <phil.dakin.1@gmail.com>
* Add bloopInstall profile Signed-off-by: Gera Shegalov <gera@apache.org> * Add bloopInstall profile Fixes NVIDIA#9621 Signed-off-by: Gera Shegalov <gera@apache.org> * add comment for install in scala2.13 Signed-off-by: Gera Shegalov <gera@apache.org> * simplify Signed-off-by: Gera Shegalov <gera@apache.org> * undo unrelated Signed-off-by: Gera Shegalov <gera@apache.org> * Apply suggestions from code review Co-authored-by: PhilDakin <phil.dakin.1@gmail.com> * review 1 Signed-off-by: Gera Shegalov <gera@apache.org> * Configurable bloopInstall phase Signed-off-by: Gera Shegalov <gera@apache.org> * move bloop config dir to execution conf Signed-off-by: Gera Shegalov <gera@apache.org> --------- Signed-off-by: Gera Shegalov <gera@apache.org> Co-authored-by: PhilDakin <phil.dakin.1@gmail.com>
PhilDakin
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
pxLi
as code owners
PhilDakin
commented
Nov 3, 2023
…able from command line. Signed-off-by: Phil Dakin <phil.dakin.1@gmail.com>
PhilDakin
force-pushed
the
pdakin.20231030.bloop_fixes
branch
from
df11232
to
8977f85
Compare
gerashegalov
reviewed
Nov 6, 2023
|
@gerashegalov how do I get more reviews? |
@PhilDakin we'll just wait for for code owners like @jlowe @tgravescs et al to respond when they get to it |
jlowe
approved these changes
Nov 7, 2023
|
build |
gerashegalov
added a commit
to gerashegalov/spark-rapids
that referenced
this pull request
Nov 14, 2023
Follow up to NVIDIA#9615 Signed-off-by: Gera Shegalov <gera@apache.org>
This was referenced Nov 14, 2023
Merged
gerashegalov
added a commit
that referenced
this pull request
Nov 17, 2023
… mode [databricks] (#9698) Fixes #9691 This PR aims at reducing unnecessary IncrementalCompiler output invalidations due to jar updates - Update build info only when the HEAD revision changes, or on clean - Produce the final aggregator jar only if the shade plugin output changed - Skip generating META-INF/ShimServiceProvider if already exists - It was not breaking anything but it does not make sense to have -Xsource:2.13 in the 2.12 build - Replace `skip` by `maven.scaladoc.skip` in docs and scripts as a follow up to #9615 - fix binary-dedupe to not look outside the target/parallel-world dir - optional skip for unpack of nightly dependencies, need a general caching solution Repeated executions Wall Clock pre-PR | Wall Clock post-PR | Maven command | -- | -- | -- | | `01:10 min` | `13.004 s` | `mvn package -pl tests -am -Dbuildver=330 \` <br> ` -Dmaven.scaladoc.skip -DskipTests` | | `01:23 min` | `25.801 s` | `mvn package -pl tests -am -Dbuildver=330 \` <br> ` -Dmaven.scaladoc.skip -Dsuffixes=rapids.CastOpSuite \`<br> ` -Dtests='Cast from string to timestamp'` | | `01:30 min` | `30.00 s` | `mvn package -Dbuildver=330 \`<br>` -Ddist.jar.compress=false -DskipTests -Dmaven.scaladoc.skip` | | `48.769 s` | `19.253 s` | `mvn -T1C package -pl dist -am -Dbuildver=330 \`<br> ` -Ddist.jar.compress=false -DskipTests \`<br> ` -Drapids.jni.unpack.skip=true` | --------- Signed-off-by: Gera Shegalov <gera@apache.org> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforces JDK11+ for Bloop builds, and builds Bloop for all targets per #9547.