Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add maven profiles for testing with AQE on or off #500

Closed
andygrove opened this issue Aug 3, 2020 · 2 comments
Closed

[FEA] Add maven profiles for testing with AQE on or off #500

andygrove opened this issue Aug 3, 2020 · 2 comments
Labels
feature request New feature or request test Only impacts tests

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We now have different code paths depending on whether AQE is enabled or not. We also support AQE with three versions of spark. We are currently not testing AQE very extensively (we just enable it on the integration tests) and this means regressions can slip in.

Describe the solution you'd like
I would like to add maven profiles to run the full Scala test suite either with AQE on or off, similar to how we use maven profiles to select the Spark version to test with.

Describe alternatives you've considered
We could run all the tests both with AQE on and off but this would take a long time to run. It would be better to have separate parallel builds in CI for each configuration we want to test.

Additional context
N/A

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify test Only impacts tests labels Aug 3, 2020
@andygrove andygrove added this to the Aug 3 - Aug 14 milestone Aug 3, 2020
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Aug 4, 2020
@revans2
Copy link
Collaborator

revans2 commented Aug 4, 2020

I am a little concerned about the impact this will have to the runtime of the tests. We already have to support Apache Spark 3.0.0, 3.0.1, and 3.1.0. We are also starting to support Databricks runtime 7.0, 7.1 and 7.2. I would much rather have us be more surgical in the tests. I'd like to see us have specific tests around the parts of AQE that we want to support, like skewed join. I'd also like to see us run some of the complex queries, like mortgage, tpch/tpcds etc with this on because it is designed for these types of queries.

@andygrove
Copy link
Contributor Author

Ok. We do already run mortgage and tpch integrationt tests both with AQE on and off. I will look into writing specific tests for skewed join as the next step.

pxLi pushed a commit to pxLi/spark-rapids that referenced this issue May 12, 2022
* Update dummy overseer agent to include dummy info

* Update key string
Add handling shutdown on dummy overseer agent
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request test Only impacts tests
Projects
None yet
Development

No branches or pull requests

3 participants