Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Enable reading floating-point types from CSV and JSON by default #5219

Closed
andygrove opened this issue Apr 12, 2022 · 1 comment
Closed

[FEA] Enable reading floating-point types from CSV and JSON by default #5219

andygrove opened this issue Apr 12, 2022 · 1 comment
Assignees
@andygrove
Labels
duplicate This issue or pull request already exists feature request New feature or request

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Reading floating-point numbers from CSV and JSON is a common operation and we would like it to be enabled by default. It was disabled by default in 22.04 due to cuDF having different precision to Java and therefore results were not the same as Spark. Now that this issue is resolved in rapidsai/cudf#10622 we should be able to enable these types by default.

Describe the solution you'd like
Enable reading float and double from CSV and JSON by default and remove the associated configuration options.

Describe alternatives you've considered
None

Additional context
None
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 12, 2022
@andygrove andygrove added this to the Apr 4 - Apr 15 milestone Apr 12, 2022
@andygrove andygrove self-assigned this Apr 12, 2022
@andygrove andygrove mentioned this issue Apr 12, 2022
Closed
@sameerz sameerz removed this from the Apr 18 - Apr 29 milestone Apr 29, 2022
@andygrove
Copy link
Contributor Author

This is now covered by #5441

@sameerz sameerz added duplicate This issue or pull request already exists and removed ? - Needs Triage Need team to review and classify labels May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
duplicate This issue or pull request already exists feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Enable reading floating-point types from CSV and JSON by default andygrove/spark-rapids
2 participants
@andygrove @sameerz