Enable optional float confs and update docs mentioning them #5441
Conversation
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
@sameerz PTAL |
There was a problem hiding this comment.
The following docs also refer to the changed configs and need to be updated:
tuning-guide.md
castStringToFloat.enabled
castFloatToString.enabled
incompatibleOps.enabled
variableFloatAgg.enabled
compatibility.md
castStringToFloat.enabled
castFloatToIntegralTypes.enabled
castFloatToString.enabled
incompatibleOps.enabled
variableFloatAgg.enabled
supported_ops.md
castFloatToString.enabled
incompatibleOps.enabled
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
I have removed this entire section
I had already updated the wordings of this doc. I don't think the variables should be removed from this doc as they still affect the compatibility
I don't think this should be changed either as this is still important for the user to read |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
@sameerz have I addressed your concerns? |
|
Can we rename this PR. "optional confs and updated docs" for what? What is being enabled. All optional confs? Just floating point? |
razajafri
changed the title
|
@revans2 Is this better now? |
|
build |
|
@sameerz I think I have addressed your concerns. PTAL |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
@sameerz I have added the section discussing the incompatible operations, the only change should be the default value. PTAL |
…e-floats Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
|
It's complaining about but it's not dead |
|
@sameerz do you have any more concerns on this PR? |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
Build |
We are enabling the float confs and their respective docs that were turned off by default before 22.06
These are the confs that were set to true in this PR
spark.rapids.sql.castDecimalToFloat.enabledspark.rapids.sql.castFloatToDecimal.enabledspark.rapids.sql.castFloatToIntegralTypes.enabledspark.rapids.sql.castFloatToString.enabledspark.rapids.sql.castStringToFloat.enabledspark.rapids.sql.csv.read.float.enabledspark.rapids.sql.json.read.float.enabledspark.rapids.sql.improvedFloatOps.enabledspark.rapids.sql.variableFloatAgg.enabledfixes #5323
Signed-off-by: Raza Jafri rjafri@nvidia.com