Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Replace whole-buffer slicing with reference count increment #585

Closed
jlowe opened this issue Aug 19, 2020 · 0 comments · Fixed by #894
Closed

[FEA] Replace whole-buffer slicing with reference count increment #585

jlowe opened this issue Aug 19, 2020 · 0 comments · Fixed by #894
Labels
feature request New feature or request good first issue Good for newcomers P2 Not required for release performance A performance related task/issue

Comments

@jlowe
Copy link
Member

jlowe commented Aug 19, 2020

There are a number of places in the plugin where we slice an entire memory buffer, i.e.: .slice(0, buffer.getLength()), to increment the reference count on the buffer. Every slice of a memory buffer creates two objects, the sliced buffer result and a sliced buffer cleaner.

This can add up when slicing during compressed shuffle, where each compressed buffer is whole-sliced by every column in every partition essentially just to increment the reference count. cudf recently added incRefCount to memory buffers, and it would create a lot less object garbage on the heap to call incRefCount on the buffer directly rather than slicing the whole buffer.

@jlowe jlowe added feature request New feature or request good first issue Good for newcomers performance A performance related task/issue P2 Not required for release labels Aug 19, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
Signed-off-by: Peixin Li <pxli@nyu.edu>

Signed-off-by: Peixin Li <pxli@nyu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers P2 Not required for release performance A performance related task/issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant