Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] don't release with any -SNAPSHOT dependencies #602

Closed
revans2 opened this issue Aug 21, 2020 · 0 comments · Fixed by #611
Closed

[FEA] don't release with any -SNAPSHOT dependencies #602

revans2 opened this issue Aug 21, 2020 · 0 comments · Fixed by #611
Assignees
Labels
build Related to CI / CD or cleanly building feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Aug 21, 2020

Is your feature request related to a problem? Please describe.
Now that we have shim layers we can support multiple versions of spark from a single jar (including unreleased SNAPSHOT versions) Generally it is bad practice to depend on a SNAPSHOT version in a release.

Describe the solution you'd like
Have a maven profile that lets us disable all of the shim layers that depend on a SNAPSHOT release. Ideally it would look at the version numbers to do this, but I don't think maven is capable of that, so we probably need to manually maintain the list of shim projects that should be a part of a release and which should not.

Would also be good to include this as a part of the pre-commit build so we know if someone broke the build by having a a release version of something depend on a non-release version. Sadly this is really only ever going to be the case for data bricks, so until we have databricks as a part of the pre-commit build we might not see a lot of success from this.

Describe alternatives you've considered
capture the spark SNAPSHOT jars this is built against so we could release it, but that might be problematic too.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 21, 2020
@revans2 revans2 self-assigned this Aug 25, 2020
@revans2 revans2 removed the ? - Needs Triage Need team to review and classify label Aug 25, 2020
@sameerz sameerz added the build Related to CI / CD or cleanly building label Sep 18, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
…IDIA#602)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants