Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] cudf_udf_test.py is flakey #746

Closed
revans2 opened this issue Sep 11, 2020 · 6 comments · Fixed by #777 or #824
Closed

[BUG] cudf_udf_test.py is flakey #746

revans2 opened this issue Sep 11, 2020 · 6 comments · Fixed by #777 or #824
Labels
bug Something isn't working P1 Nice to have for release

Comments

@revans2
Copy link
Collaborator

revans2 commented Sep 11, 2020

All of the tests in cudf_udf_test.py fail periodically and need to be fixed.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 11, 2020
@firestarman
Copy link
Collaborator

Any log and the error snip ? I guess it could be OOM error.

@sameerz sameerz added P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Sep 15, 2020
@sameerz
Copy link
Collaborator

sameerz commented Sep 15, 2020

Marking as P2, @GaryShen2008 please confirm whether this test is required for the pandas cudf functionality.

@firestarman firestarman linked a pull request Sep 16, 2020 that will close this issue
Enable tests in udf_cudf_test.py #777
Merged
@revans2 revans2 mentioned this issue Sep 18, 2020
Merged
@tgravescs tgravescs reopened this Sep 18, 2020
@tgravescs
Copy link
Collaborator

reverting change with #813 due to tests failing in dev environment

@tgravescs
Copy link
Collaborator

also, even if these are off by default I would like to see proper documentation on how someone would run them as to what extra dependencies and commands are needed.

@GaryShen2008
Copy link
Collaborator

@firestarman It seems we only considered the docker environment and forgot the dev environment. May need more docs to explain how to run it or add some checking in test code.

@firestarman
Copy link
Collaborator

@shotai is working on it

@shotai shotai mentioned this issue Sep 22, 2020
Merged
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 6d2a4f07d3cd22ae72393b03f86a01b32de82ed1 (NV…
0089a54 
…IDIA#746)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P1 Nice to have for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable tests in udf_cudf_test.py firestarman/spark-rapids
Skip cudf_udf test by default
5 participants
@revans2 @tgravescs @sameerz @firestarman @GaryShen2008