-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] conditionals_test.py::test_conditional_with_side_effects_cast[String] failed with DATAGEN_SEED=1701976979 #9992
Comments
Yup if I update the test to escape the z more we get an error because we cannot support it on the GPU. But using a $ works. But I don't think that is the right solution because we might have We probably want to update test_conditional_with_side_effects_case_when too that is doing something similar. But we also want to update the generated data to make it actually hit the various parts and verify that the input/output data looks correct. |
This is an instance where the test is not accounting for the need to Currently the test ends up using the regex And the seed produces a string starting with
|
@gerashegalov for this test, the Is that intended? I am going through various places where we'd like to mark the override |
Fixes NVIDIA#9992 Addendum to NVIDIA#10090 Signed-off-by: Gera Shegalov <gera@apache.org>
Describe the bug
Causes this to fail all the time. It looks like it is a test error because this is failing on the CPU with no GPU code running. I think it is related to the RLIKE that runs, but I am not 100% sure. Probably the \z is not escaping things properly.
The text was updated successfully, but these errors were encountered: