-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 332db build failure [databricks] #10070
Fix 332db build failure [databricks] #10070
Conversation
Signed-off-by: Andy Grove <andygrove@nvidia.com>
build |
build |
Any context on why this started to fail? The line was added 3 years ago |
Is it due to new DBX Spark version we support? |
Databricks Runtime releases maintenance updates bi-weekly. So presumably in the mid-December update they relaxed the signature for Also see #8587. Of note is that per #1320 we actually do not run unit / ScalaTests on Databricks. We could stop building test jars there. |
build |
* Added 351 snapshot shim * Signing off Signed-off-by: Raza Jafri <rjafri@nvidia.com> * updated 2.13 pom.xml * Fixed Decimal 128 Multiplication * added comments to highlight the change in multiply128 * Removed the import alias * Fixed Sequence size limit check * changes to use the new multiply128. Changed the name of the shim to reflect the method name * Handle empty partitions * pulled in change from #10070 * Fixed the overflow check for addition and subtraction * Updated test conditions * Revert "Updated test conditions" This reverts commit 533504f. * addressed review comments * renamed --------- Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Closes #10063
Builds were failing with:
This PR makes the method public to fix the compilation error.