Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_unsupported_fallback_regexp_replace #10093

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Fix test_unsupported_fallback_regexp_replace #10093

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c08996
Fix test_unsupported_fallback_regexp_replace
thirtiseven Dec 25, 2023
155a8d7
Use raw string
thirtiseven Dec 26, 2023
93fe145
address comment
thirtiseven Dec 28, 2023
9fab29e
Recover mk_str_gen
thirtiseven Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration_tests/src/main/python/regexp_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
_regexp_conf = { 'spark.rapids.sql.regexp.enabled': True }

def mk_str_gen(pattern):
return StringGen(pattern).with_special_case('').with_special_pattern('.{0,10}')
return StringGen(pattern).with_special_case('')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change still here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


def test_split_re_negative_limit():
data_gen = mk_str_gen('([bf]o{0,2}:){1,7}') \
Expand Down Expand Up @@ -939,7 +939,7 @@ def assert_gpu_did_fallback(sql_text):

@allow_non_gpu('ProjectExec', 'RegExpReplace')
def test_unsupported_fallback_regexp_replace():
gen = mk_str_gen('[abcdef]{0,2}')
gen = StringGen('[abcdef]{0,2}').with_special_case('').with_special_pattern(r'[^\\$]{0,10}')
regex_gen = StringGen(r'\[a-z\]\+')
def assert_gpu_did_fallback(sql_text):
assert_gpu_fallback_collect(lambda spark:
Expand Down