Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge conflict with branch-23.12 #10127

Merged
merged 6 commits into from
Dec 29, 2023
Merged

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Dec 29, 2023

Fixes the merge conflict noted in #10120. All conflicts were resolved by taking the branch-24.02 version.

NOTE: This must be merged with a merged commit, not squashed!

GaryShen2008 and others added 6 commits December 29, 2023 16:15
Signed-off-by: Gary Shen <gashen@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
1, Init changelog with

```
GITHUB_TOKEN=<> scripts/generate-changelog --releases=23.10,23.12
```

2, move 23.08 content to archives folder

Signed-off-by: Tim Liu <timl@nvidia.com>
Signed-off-by: Tim Liu <timl@nvidia.com>
1, Init changelog with

```
GITHUB_TOKEN=<> scripts/generate-changelog --releases=23.10,23.12
```

Signed-off-by: Tim Liu <timl@nvidia.com>
@jlowe jlowe added the build Related to CI / CD or cleanly building label Dec 29, 2023
@jlowe jlowe self-assigned this Dec 29, 2023
@jlowe
Copy link
Member Author

jlowe commented Dec 29, 2023

build

Copy link
Collaborator

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming build passes.

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Could make it [skip ci]

@jlowe jlowe merged commit 142dead into NVIDIA:branch-24.02 Dec 29, 2023
39 of 40 checks passed
@jlowe jlowe deleted the fix-merge branch December 29, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants