Change Hash Aggregate to allow pass-through on MapType #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhushukla
added
feature request
Signed-off-by: Kuhu Shukla <kuhus@nvidia.com>
kuhushukla
force-pushed
the
hash_agg_maptype_wl
branch
from
a7ee5c3
to
b98dcda
Compare
revans2
reviewed
Oct 23, 2020
revans2
approved these changes
Oct 23, 2020
kuhushukla
changed the title
…into hash_agg_maptype_wl
|
build |
jlowe
changed the title
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
* Change Hash Aggregate to allow pass through on MapType Signed-off-by: Kuhu Shukla <kuhus@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Change Hash Aggregate to allow pass through on MapType Signed-off-by: Kuhu Shukla <kuhus@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Change Hash Aggregate to allow pass through on MapType Signed-off-by: Kuhu Shukla <kuhus@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: Peixin Li <pxli@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #984 and should not be really merged ahead of it. I whitelist the MapType for HashAggregate and tag it as unsupported on the individual operators like count, max etc.
My target test query shows a different replacement issue we know from md5 being unsupported after this change which is expected and does not complain about the data type anymore, which makes me think this is a step in the right direction.