Smoke test with '--package' to fetch the plugin jar #10238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix NVIDIA#10160 Run SPARK_SHELL_SMOKE_TEST with '--package' to fetch the plugin jar Can downloading the plugin jar from specified artifact repo by '--repositories' This test can fetch plugin jar from internal maven repo, maven central, or Sonatype staging repo. Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
added
bug
NvTimLiu
requested review from
gerashegalov,
mattahrens,
sameerz,
yinqingh and
YanxuanLiu
NvTimLiu
requested review from
jlowe,
revans2,
tgravescs and
GaryShen2008
as code owners
NvTimLiu
commented
Jan 22, 2024
jlowe
reviewed
Jan 22, 2024
This suggestion is reasonable Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Tim Liu <timl@nvidia.com>
|
build |
|
CI failed due to |
|
build |
jlowe
approved these changes
Jan 23, 2024
NvTimLiu
commented
Jan 26, 2024
| @@ -304,6 +304,11 @@ if [[ $TEST_MODE == "DEFAULT" ]]; then | |||
| PYSP_TEST_spark_shuffle_manager=com.nvidia.spark.rapids.${SHUFFLE_SPARK_SHIM}.RapidsShuffleManager \ | |||
| ./run_pyspark_from_build.sh | |||
|
|
|||
| SPARK_SHELL_SMOKE_TEST=1 \ | |||
There was a problem hiding this comment.
There is a limitation in Spark that spark currently does not support classifiers with --packages, https://issues.apache.org/jira/browse/SPARK-20075
It only works on the default cuda11 jar, Can not work on cuda12 and arm64 classifiers
all tests should eventually disable UI #10227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #10160
Run SPARK_SHELL_SMOKE_TEST with '--package' to fetch the plugin jar
Can downloading the plugin jar from specified artifact repo by '--repositories'
This test can fetch plugin jar from internal maven repo, maven central, or Sonatype staging repo.
Signed-off-by: Tim Liu timl@nvidia.com