Support barrier mode for mapInPandas/mapInArrow #10343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
|
build |
firestarman
reviewed
Jan 31, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/python/GpuMapInBatchExec.scala
Show resolved
Hide resolved
firestarman
reviewed
Jan 31, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/python/GpuMapInPandasExec.scala
Show resolved
Hide resolved
|
build |
firestarman
reviewed
Jan 31, 2024
firestarman
reviewed
Jan 31, 2024
|
build |
firestarman
approved these changes
Feb 1, 2024
firestarman
reviewed
Feb 1, 2024
| @@ -33,7 +34,7 @@ | |||
| raise AssertionError("incorrect pyarrow version during required testing " + str(e)) | |||
| pytestmark = pytest.mark.skip(reason=str(e)) | |||
|
|
|||
| from asserts import assert_gpu_and_cpu_are_equal_collect, assert_gpu_fallback_collect | |||
| from asserts import assert_gpu_and_cpu_are_equal_collect, assert_gpu_fallback_collect, assert_equal | |||
There was a problem hiding this comment.
NIT: An useless import to assert_equal
There was a problem hiding this comment.
Yeah, good finding. Let's remove it in other PR that affects this file.
wbo4958
added a commit
to wbo4958/spark-rapids
that referenced
this pull request
Feb 1, 2024
This reverts commit 6723a68. Signed-off-by: Bobby Wang <wbo4958@gmail.com>
wbo4958
added a commit
to wbo4958/spark-rapids
that referenced
this pull request
Feb 1, 2024
This reverts commit 6723a68.
jlowe
pushed a commit
that referenced
this pull request
Feb 1, 2024
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #10344
Spark 3.5 has introduced a new feature supporting barrier mode for mapInPandas/mapInArrow, more detail can be found at https://issues.apache.org/jira/browse/SPARK-42896. However, spark-rapids missed this feature which resulted in unexpected behavior. For example
The same tasks of the above code will run on barrier mode on the CPU, while on
non-barriermode on the GPU with spark-rapids.