[FEA] Support Databricks 7.3 LTS Runtime #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
addressed review comments, code compiles on databricks currently running the tests there, putting it up here to run the regular tests in parallel, so please hold off on merging til I say databricks tests are done |
|
build |
|
build |
|
build |
jlowe
previously approved these changes
Nov 6, 2020
jlowe
previously approved these changes
Nov 6, 2020
|
build |
jlowe
approved these changes
Nov 6, 2020
|
tests passed on databricks |
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
* Add databricks 301 shim layer * copy rest of 300db files * update to build databricks 300 and 301 separately * update profile name * Fix missing include * fixes * changes * Fixes * databricks changes 3.0.1 * Fix broadcast like * Fix broadcast hash join to be a "like" one * remove functions in the 301 base class * Update build scripts to use more from mvn properties * Fix order of variables * comment out slck for now * Fix missing variables * update docs and build args * use quotes for profeiles * python escape Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove %q * debug * Fix maven location install * rearrange * Fix version parameter * add bck shutdown * increase timeout * update deploy script * fix comment * fix deploy dir * update * add back in tests * minor updates * put slack back * Upmerge, fix copyright, and remove extra import * cleanup imports Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove a couple more imports * remove ZoneId import Signed-off-by: Thomas Graves <tgraves@nvidia.com> * upmerge to the latest changes to GpuHashJoin * Add fail on error for version file generation * revert fail on error in pom file
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add databricks 301 shim layer * copy rest of 300db files * update to build databricks 300 and 301 separately * update profile name * Fix missing include * fixes * changes * Fixes * databricks changes 3.0.1 * Fix broadcast like * Fix broadcast hash join to be a "like" one * remove functions in the 301 base class * Update build scripts to use more from mvn properties * Fix order of variables * comment out slck for now * Fix missing variables * update docs and build args * use quotes for profeiles * python escape Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove %q * debug * Fix maven location install * rearrange * Fix version parameter * add bck shutdown * increase timeout * update deploy script * fix comment * fix deploy dir * update * add back in tests * minor updates * put slack back * Upmerge, fix copyright, and remove extra import * cleanup imports Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove a couple more imports * remove ZoneId import Signed-off-by: Thomas Graves <tgraves@nvidia.com> * upmerge to the latest changes to GpuHashJoin * Add fail on error for version file generation * revert fail on error in pom file
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add databricks 301 shim layer * copy rest of 300db files * update to build databricks 300 and 301 separately * update profile name * Fix missing include * fixes * changes * Fixes * databricks changes 3.0.1 * Fix broadcast like * Fix broadcast hash join to be a "like" one * remove functions in the 301 base class * Update build scripts to use more from mvn properties * Fix order of variables * comment out slck for now * Fix missing variables * update docs and build args * use quotes for profeiles * python escape Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove %q * debug * Fix maven location install * rearrange * Fix version parameter * add bck shutdown * increase timeout * update deploy script * fix comment * fix deploy dir * update * add back in tests * minor updates * put slack back * Upmerge, fix copyright, and remove extra import * cleanup imports Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove a couple more imports * remove ZoneId import Signed-off-by: Thomas Graves <tgraves@nvidia.com> * upmerge to the latest changes to GpuHashJoin * Add fail on error for version file generation * revert fail on error in pom file
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
[auto-merge] bot-auto-merge-branch-23.04 to branch-23.06 [skip ci] [bot]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes 502
This adds a Databricks shim for spark 3.0.1 - runtime 7.3.
Unfortunately I copied a lot of code from the spark 3.0.0 databricks version. I can't build both at the same time since I have to spin up different clusters with different versions.
I cleaned up some of the build scripts to not need as many parameters and just get the data from maven pom files.
Since this is 3.0.1 some of the files also use the shuffleLike classes, which was an attempt to make AQE work. Unfortunately we still can't support that due to other databricks classes.
The integration tests all pass with AQE disabled and I verified the jenkins files work properly by running them from dev. I did file a followup issue to document the databricks limitations and update anything else I may have missed.