-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ErrorClass to Throw AnalysisException [databricks] #10830
Merged
razajafri
merged 19 commits into
NVIDIA:branch-24.08
from
razajafri:SP-9259-analysis-exception
Jun 4, 2024
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
79a72d5
AnalysisException child class
razajafri 72caee0
Use errorClass for reporting AnalysisException
razajafri 0f765c9
POM changes
razajafri d6b1974
Merge remote-tracking branch 'origin/branch-24.06' into SP-9259-analy…
razajafri a534c5a
Reuse the RapidsErrorUtils to throw the AnalysisException
razajafri 88a2673
Revert "POM changes"
razajafri 6bebb21
Updated copyrights
razajafri f967002
Added the TrampolineUtil method back to handle cases which don't use …
razajafri d930fdf
Add doc to the RapidsAnalysisException
razajafri b965a31
Merge remote-tracking branch 'origin/branch-24.08' into SP-9259-analy…
razajafri 9156047
addressed review comments
razajafri 66bd324
Merge remote-tracking branch 'origin/branch-24.08' into SP-9259-analy…
razajafri 9cf1045
Fixed imports
razajafri 68645ed
Moved the RapidsAnalysisException out of TrampolineUtil
razajafri 6d8391f
fixed imports
razajafri b1a482f
Merge remote-tracking branch 'origin/branch-24.08' into SP-9259-analy…
razajafri 1d70273
addressed review comments
razajafri 45718e9
fixed unused import
razajafri 65cb71a
Removed the TrampolineUtil method for throwing RapidsAnalysisException
razajafri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we need a TrampolineUtil method to use one of our own classes. Why not have the class that would use this method simply throw RapidsAnalysisException directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need a
TrampolineUtil
method, this was a remnant of throwing the AnalysisException.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me get rid of that. Please let me know if there are any other concerns