Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Multiple Filtering Keys for Subquery Broadcast #10858

Merged
merged 3 commits into from
May 28, 2024
Merged

Add Support for Multiple Filtering Keys for Subquery Broadcast #10858

merged 3 commits into from
May 28, 2024

Conversation

razajafri
Copy link
Collaborator

@razajafri razajafri commented May 22, 2024 •
edited
Loading

This PR adds support for passing multiple filtering keys to the GpuSubqueryBroadcastExec

contributes to #9259
fixes #10669

@razajafri razajafri requested a review from NVnavkumar May 22, 2024 01:15
@razajafri
Signing off
491ab4e 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
NVnavkumar
NVnavkumar reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@NVnavkumar NVnavkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally look good to me. Is there an integration test we can add for Spark 4.0.0 that uses multiple filtering keys?

@sameerz sameerz added the Spark 4.0+ Spark 4.0+ issues label May 22, 2024
@razajafri razajafri mentioned this pull request May 23, 2024
Open
@razajafri
Copy link
Collaborator Author

Generally look good to me. Is there an integration test we can add for Spark 4.0.0 that uses multiple filtering keys?

As discussed offline, we will handle this as a follow-on in #10880

@razajafri
Copy link
Collaborator Author

build

NVnavkumar
NVnavkumar previously approved these changes May 23, 2024
View reviewed changes
@razajafri
Copy link
Collaborator Author

build

@razajafri razajafri merged commit 3001852 into NVIDIA:branch-24.06 May 28, 2024
44 checks passed
@razajafri razajafri deleted the SP-9259-multiple-filtering-keys branch May 28, 2024 15:31
@razajafri razajafri mentioned this pull request May 28, 2024
Merged
razajafri added a commit that referenced this pull request May 28, 2024
@razajafri
Revert "Add Support for Multiple Filtering Keys for Subquery Broadcast (
16c2b99 
#10858)"

This reverts commit 3001852.
@razajafri razajafri mentioned this pull request May 28, 2024
Merged
razajafri added a commit that referenced this pull request May 29, 2024
@razajafri
Revert "Add Support for Multiple Filtering Keys for Subquery Broadcas…
bb05b17 
…t " (#10934)

* Revert "Add Support for Multiple Filtering Keys for Subquery Broadcast  (#10858)"

This reverts commit 3001852.

* Signing off

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

---------

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@NvTimLiu NvTimLiu mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NVnavkumar NVnavkumar NVnavkumar approved these changes

Assignees
No one assigned
Labels
Spark 4.0+ Spark 4.0+ issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supporting broadcast of multiple filtering keys in DynamicPruning
3 participants
@razajafri @NVnavkumar @sameerz