Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up test performance using pytest-xdist #1086

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Nov 7, 2020

This covers the same work that was done in #1022 but finishes it.

It now will also autodetect the parallelism by default so we can ideally run as fast as possible in the normal case.

It also falls back to slower processing if pytest-xdist cannot be found.

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2
Copy link
Collaborator Author

revans2 commented Nov 7, 2020

build

@revans2
Copy link
Collaborator Author

revans2 commented Nov 7, 2020

build

@revans2
Copy link
Collaborator Author

revans2 commented Nov 9, 2020

build

Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if I'm running the tests through maven and want to override the parallelism, I set TEST_PARALLEL=1 in the env?

docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
@revans2
Copy link
Collaborator Author

revans2 commented Nov 9, 2020

so if I'm running the tests through maven and want to override the parallelism, I set TEST_PARALLEL=1 in the env?

You would want to add -Dpytest.TEST_PARALLEL=1 to your command line. If you are running through maven I think it is better to do it with maven.

@revans2 revans2 added the test Only impacts tests label Nov 9, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Nov 9, 2020

build

@revans2 revans2 merged commit 65bc02e into NVIDIA:branch-0.3 Nov 9, 2020
@revans2 revans2 deleted the xdist-pytest branch November 9, 2020 17:43
sperlingxx pushed a commit to sperlingxx/spark-rapids that referenced this pull request Nov 20, 2020
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#1086)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants