Update how we deal with type checking #1099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at how complex nested type checking is going to be combined with decimal type checking in #1063 @jlowe and I decided that we needed a more complete solution. This is hopefully that solution. It is a little bit ugly but it provides a fairly clean and consistent way to cover all of our existing checks and also updates it for decimal, Array, Struct, and Map support.
It does not prevent users from overriding the type check and doing it all themselves, but that should be very rare instead of common like it is now.