-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing the Named Parameter change in Spark 4.0.0 [databricks] #10992
Addressing the Named Parameter change in Spark 4.0.0 [databricks] #10992
Conversation
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
build |
build |
341db instance failed to start
|
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but could be a way smaller change
@@ -65,24 +65,27 @@ class GpuInSubqueryExecSuite extends SparkQueryCompareTestSuite { | |||
|
|||
private def buildCpuInSubqueryPlan( | |||
spark: SparkSession, | |||
shouldBroadcast: Boolean): SparkPlan = { | |||
shouldBroadcastOrDpp: Boolean): SparkPlan = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference is to minimize the change. I would leave the name as is, then we could have the whole patch a one-line change
build |
…0992) Signed-off-by: Raza Jafri <rjafri@nvidia.com>
This PR addresses the change in Spark of renaming the named parameter
shouldBroadcast
toisDynamicPruning
in this change.We have taken the approach of overloading the naming of the variable and passing the parameter without naming it.
contributes to #9259