Concat() Exception bug fix #11039
Merged
Concat() Exception bug fix #11039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
Feng-Jiang28
changed the title
thirtiseven
reviewed
Jun 11, 2024
tests/src/test/spark330/scala/org/apache/spark/sql/rapids/utils/RapidsTestSettings.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: fejiang <fejiang@nvidia.com>
|
build |
2 similar comments
|
build |
|
build |
Signed-off-by: fejiang <fejiang@nvidia.com>
|
build |
1 similar comment
|
build |
Feng-Jiang28
changed the title
|
LGTM |
Feng-Jiang28
added a commit
that referenced
this pull request
Jun 13, 2024
This reverts commit 73d76cf.
|
Fixes #10925 |
SurajAralihalli
pushed a commit
to SurajAralihalli/spark-rapids
that referenced
this pull request
Jul 12, 2024
* concat_null_bug_fix Signed-off-by: fejiang <fejiang@nvidia.com> * concat_null_bug_fix Signed-off-by: fejiang <fejiang@nvidia.com> * Setting modified Signed-off-by: fejiang <fejiang@nvidia.com> * remove comment Signed-off-by: fejiang <fejiang@nvidia.com> * concat considered as empty string Signed-off-by: fejiang <fejiang@nvidia.com> --------- Signed-off-by: fejiang <fejiang@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #10925.
Here an empty concat is expecting a GpuScalar instead of a Scalar type, or there will be IllegalArgumentException.
Local UT has passed.