stop using copyWithBooleanColumnAsValidity [databricks] #11418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
ttnghia
reviewed
Sep 3, 2024
Comment on lines
397
to
398
| withResource(Scalar.fromNull(millis.getType)) { NULL => | ||
| overflowFlags.ifElse(millis, NULL) |
There was a problem hiding this comment.
In general we should avoid using keyword names such as null or NULL.
Suggested change
| withResource(Scalar.fromNull(millis.getType)) { NULL => | |
| overflowFlags.ifElse(millis, NULL) | |
| withResource(Scalar.fromNull(millis.getType)) { nullVal => | |
| overflowFlags.ifElse(millis, nullVal) |
firestarman
previously approved these changes
Sep 3, 2024
|
build |
pxLi
changed the title
|
build |
wjxiz1992
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
approve, local query test pass without seeing error of
/home/jenkins/agent/workspace/jenkins-spark-rapids-customer-test-build-141/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOrcScan.scala:397: value copyWithBooleanColumnAsValidity is not a member of ai.rapids.cudf.ColumnVector
any more. Thanks for the quick fix!
ttnghia
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to #11397
stop using copyWithBooleanColumnAsValidity
#11399 did not remove all the
copyWithBooleanColumnAsValiditySigned-off-by: Chong Gao res_life@163.com