backport fixes of #11573 to branch 24.10 #11588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use task id as tie breaker Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> * save threadlocal lookup Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> --------- Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>
Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>
|
build |
jlowe
approved these changes
Oct 11, 2024
Comment on lines
+52
to
+53
| } | ||
| else if (!canAcquire(numPermits)) { |
There was a problem hiding this comment.
Suggested change
| } | |
| else if (!canAcquire(numPermits)) { | |
| } else if (!canAcquire(numPermits)) { |
sameerz
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11573 is fixed by #11574 + #11587 on branch 24.12
This PR is to backport these changes to 24.10, as suggested by @jlowe and @revans2