Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable NullType for First and Last in 3.0.1+ #1189

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Enable NullType for First and Last in 3.0.1+ #1189

merged 1 commit into from
Nov 23, 2020

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Nov 23, 2020

This fixes #1185

@revans2
Enable NullType for First and Last in 3.0.1+
e0b8c2b 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added the bug Something isn't working label Nov 23, 2020
@revans2 revans2 added this to the Nov 23 - Dec 4 milestone Nov 23, 2020
@revans2 revans2 self-assigned this Nov 23, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Nov 23, 2020

build

tgravescs
tgravescs approved these changes Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't have pre merge running 3.0.1 at this point still?

@revans2
Copy link
Collaborator Author

revans2 commented Nov 23, 2020

I guess we don't have pre merge running 3.0.1 at this point still?

Nope. I am running it locally right now to verify that 3.0.1 all passes and then I am going to run against 3.1.0-SNAPSHOT too, just to be sure.

@kuhushukla
Copy link
Collaborator

Curious if 3.0.1 integration tests are not part of premerge.

@revans2
Copy link
Collaborator Author

revans2 commented Nov 23, 2020

3.0.1 passed, doing 3.1.0 now

@jlowe
Copy link
Member

jlowe commented Nov 23, 2020

I guess we don't have pre merge running 3.0.1 at this point still?

It runs the unit tests in premerge against 3.0.0, 3.0.1, and 3.1.0 but the integration tests only run against 3.0.0.

@revans2
Copy link
Collaborator Author

revans2 commented Nov 23, 2020

3.1.0-SNAPSHOT just passed too.

@revans2 revans2 merged commit a891340 into NVIDIA:branch-0.3 Nov 23, 2020
@revans2 revans2 deleted the null_fist_failure branch November 23, 2020 21:37
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@revans2
Enable NullType for First and Last in 3.0.1+ (NVIDIA#1189)
4f77c87 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@revans2
Enable NullType for First and Last in 3.0.1+ (NVIDIA#1189)
a11d750 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
@nvauto
Update submodule cudf to 6bb0328148cb3f66693487da5c714b11d1051831 (NV…
610e562 
…IDIA#1189)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@tgravescs tgravescs tgravescs approved these changes

@kuhushukla kuhushukla kuhushukla approved these changes

Assignees

@revans2 revans2

Labels
bug Something isn't working
Projects
None yet
Milestone
Nov 23 - Dec 4
Development

Successfully merging this pull request may close these issues.

[BUG] test_hash_multiple_mode_query failing
4 participants
@revans2 @kuhushukla @jlowe @tgravescs