[REVIEW] Support GpuFilter and GpuCoalesceBatches for decimal data #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
sperlingxx
force-pushed
the
dec_conti_table_test
branch
from
705bc05
to
b04e5b1
Compare
|
build |
|
The integration tests started to crash after this change. I am not 100% sure what happened but a lot of the tests started to get errors not being able to connect to the JVM process which makes me think that it crashed. (you could try running with TEST_PARALLEL=0 in your environment to get the tests to spit out more info about the run, but it will take longer) |
|
You can probably also look at |
|
OK I am investigating it |
|
build |
1 similar comment
|
build |
|
build |
jlowe
reviewed
Dec 1, 2020
tests/src/test/scala/com/nvidia/spark/rapids/FilterExprSuite.scala
Outdated
Show resolved
Hide resolved
…cala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
jlowe
approved these changes
Dec 1, 2020
|
build |
|
build |
|
build |
1 similar comment
|
build |
|
rebuild |
|
build |
2 similar comments
|
build |
|
build |
revans2
approved these changes
Dec 3, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: sperlingxx <lovedreamf@gmail.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: sperlingxx <lovedreamf@gmail.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1192) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both PR to enable
cudf::apply_boolean_maskfor decimal and PR to enablecudf::contiguous_splitfor decimal are ready, we can supportGpuCoalesceBatchesandGpuFilter(which relied onGpuCoalesceBatches).This PR is to enable
GpuFilterfor decimal type. And related tests forGpuFilterandGpuCoalesceBatchesare also provided.In this PR,
isNotNullis used as predicate of decimal filter because relational operators for decimal type are still unsupported.