Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spark 3.1 shim for ShuffleOrigin shuffle parameter #1206

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Nov 25, 2020

Spark 3.1 changed ShuffleExchangeLike to remove the canChangeNumPartitions method and replaced it with a shuffle origin instead. This updates the shims to pass the original CPU shuffle exec node when asking for a GPU shuffle exec node rather than fetching the canChangeNumPartitions field out of it which won't be present on some Spark versions.

@jlowe jlowe added the Spark 3.1+ Bugs only related to Spark 3.1 or higher label Nov 25, 2020
@jlowe jlowe added this to the Nov 23 - Dec 4 milestone Nov 25, 2020
@jlowe jlowe self-assigned this Nov 25, 2020
@jlowe
Copy link
Member Author

jlowe commented Nov 25, 2020

build

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe
Copy link
Member Author

jlowe commented Nov 25, 2020

build

@jlowe jlowe merged commit efc106e into NVIDIA:branch-0.3 Nov 25, 2020
kuhushukla pushed a commit to kuhushukla/spark-rapids that referenced this pull request Nov 30, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@jlowe jlowe deleted the fix-spark31-shuffle-origin branch September 10, 2021 15:41
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#1206)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spark 3.1+ Bugs only related to Spark 3.1 or higher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants